2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Stuart Hayes <[email protected]> commit dd65c736d1b5312c80c88a64bf521db4959eded5 upstream. The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI handler looks at certain registers and memory locations, so the SMI needs to happen immediately. On some systems I/O writes are posted, though, causing the SMI to happen well after the "outb" occurred, which causes random failures. Following the "outb" with an "inb" forces the write to go through even if it is posted. Signed-off-by: Stuart Hayes <[email protected]> Acked-by: Doug Warzecha <[email protected]> Signed-off-by: Andi Kleen <[email protected]> Cc: Chuck Ebbert <[email protected]> Signed-off-by: Jiri Kosina <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/firmware/dcdbas.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux-2.6.35.y/drivers/firmware/dcdbas.c =================================================================== --- linux-2.6.35.y.orig/drivers/firmware/dcdbas.c 2011-03-29 22:50:16.283841755 -0700 +++ linux-2.6.35.y/drivers/firmware/dcdbas.c 2011-03-29 23:03:03.249217032 -0700 @@ -268,8 +268,10 @@ } /* generate SMI */ + /* inb to force posted write through and make SMI happen now */ asm volatile ( - "outb %b0,%w1" + "outb %b0,%w1\n" + "inb %w1" : /* no output args */ : "a" (smi_cmd->command_code), "d" (smi_cmd->command_address), _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
