2.6.35-longterm review patch.  If anyone has any objections, please let me know.

------------------
From: Jiri Slaby <[email protected]>

commit 6960f40a954619857e7095a6179eef896f297077 upstream.

Make sure that we check the return value of tty_port_tty_get.
Sometimes it may return NULL and we later dereference that.

The only place here is in kobil_read_int_callback, so fix it.

Signed-off-by: Jiri Slaby <[email protected]>
Signed-off-by: Andi Kleen <[email protected]>
Cc: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 drivers/usb/serial/kobil_sct.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.35.y/drivers/usb/serial/kobil_sct.c
===================================================================
--- linux-2.6.35.y.orig/drivers/usb/serial/kobil_sct.c  2011-03-29 
22:50:40.699217027 -0700
+++ linux-2.6.35.y/drivers/usb/serial/kobil_sct.c       2011-03-29 
23:03:02.423238165 -0700
@@ -372,7 +372,7 @@
        }
 
        tty = tty_port_tty_get(&port->port);
-       if (urb->actual_length) {
+       if (tty && urb->actual_length) {
 
                /* BEGIN DEBUG */
                /*

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to