2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Namhyung Kim <[email protected]> commit 571428be550fbe37160596995e96ad398873fcbd upstream. free_user() releases uidhash_lock but was missing annotation. Add it. This removes following sparse warnings: include/linux/spinlock.h:339:9: warning: context imbalance in 'free_user' - unexpected unlock kernel/user.c:120:6: warning: context imbalance in 'free_uid' - wrong count at exit Signed-off-by: Namhyung Kim <[email protected]> Signed-off-by: Andi Kleen <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Dhaval Giani <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Mike Galbraith <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- kernel/user.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6.35.y/kernel/user.c =================================================================== --- linux-2.6.35.y.orig/kernel/user.c 2011-03-29 22:51:25.263076751 -0700 +++ linux-2.6.35.y/kernel/user.c 2011-03-29 23:03:00.463288316 -0700 @@ -91,6 +91,7 @@ * upon function exit. */ static void free_user(struct user_struct *up, unsigned long flags) + __releases(&uidhash_lock) { uid_hash_remove(up); spin_unlock_irqrestore(&uidhash_lock, flags); _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
