2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Christian Lamparter <[email protected]> commit 3b5c5827d1f80ad8ae844a8b1183f59ddb90fe25 upstream. P54_HDR_FLAG_DATA_OUT_SEQNR is meant to tell the firmware that "the frame's sequence number has already been set by the application." Whereas IEEE80211_TX_CTL_ASSIGN_SEQ is set for frames which lack a valid sequence number and either the driver or firmware has to assign one. Yup, it's the exact opposite! Signed-off-by: Christian Lamparter <[email protected]> Signed-off-by: John W. Linville <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Andi Kleen <[email protected]> --- drivers/net/wireless/p54/txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.35.y/drivers/net/wireless/p54/txrx.c =================================================================== --- linux-2.6.35.y.orig/drivers/net/wireless/p54/txrx.c 2011-03-29 22:51:46.583531213 -0700 +++ linux-2.6.35.y/drivers/net/wireless/p54/txrx.c 2011-03-29 23:02:59.358316589 -0700 @@ -616,7 +616,7 @@ else *burst_possible = false; - if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) + if (!(info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ)) *flags |= P54_HDR_FLAG_DATA_OUT_SEQNR; if (info->flags & IEEE80211_TX_CTL_PSPOLL_RESPONSE) _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
