This is a note to let you know that I've just added the patch titled

    ipv6: netfilter: ip6_tables: fix infoleak to userspace

to the 2.6.32-longterm tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/longterm/longterm-queue-2.6.32.git;a=summary

The filename of the patch is:
     ipv6-netfilter-ip6_tables-fix-infoleak-to-userspace.patch
and it can be found in the queue-2.6.32 subdirectory.

If you, or anyone else, feels it should not be added to the 2.6.32 longterm 
tree,
please let <[email protected]> know about it.


>From 6a8ab060779779de8aea92ce3337ca348f973f54 Mon Sep 17 00:00:00 2001
From: Vasiliy Kulikov <[email protected]>
Date: Tue, 15 Mar 2011 13:37:13 +0100
Subject: ipv6: netfilter: ip6_tables: fix infoleak to userspace

From: Vasiliy Kulikov <[email protected]>

commit 6a8ab060779779de8aea92ce3337ca348f973f54 upstream.

Structures ip6t_replace, compat_ip6t_replace, and xt_get_revision are
copied from userspace.  Fields of these structs that are
zero-terminated strings are not checked.  When they are used as argument
to a format string containing "%s" in request_module(), some sensitive
information is leaked to userspace via argument of spawned modprobe
process.

The first bug was introduced before the git epoch;  the second was
introduced in 3bc3fe5e (v2.6.25-rc1);  the third is introduced by
6b7d31fc (v2.6.15-rc1).  To trigger the bug one should have
CAP_NET_ADMIN.

Signed-off-by: Vasiliy Kulikov <[email protected]>
Signed-off-by: Patrick McHardy <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 net/ipv6/netfilter/ip6_tables.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/net/ipv6/netfilter/ip6_tables.c
+++ b/net/ipv6/netfilter/ip6_tables.c
@@ -1323,6 +1323,7 @@ do_replace(struct net *net, void __user
        /* overflow check */
        if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
                return -ENOMEM;
+       tmp.name[sizeof(tmp.name)-1] = 0;
 
        newinfo = xt_alloc_table_info(tmp.size);
        if (!newinfo)
@@ -1855,6 +1856,7 @@ compat_do_replace(struct net *net, void
                return -ENOMEM;
        if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
                return -ENOMEM;
+       tmp.name[sizeof(tmp.name)-1] = 0;
 
        newinfo = xt_alloc_table_info(tmp.size);
        if (!newinfo)
@@ -2079,6 +2081,7 @@ do_ip6t_get_ctl(struct sock *sk, int cmd
                        ret = -EFAULT;
                        break;
                }
+               rev.name[sizeof(rev.name)-1] = 0;
 
                if (cmd == IP6T_SO_GET_REVISION_TARGET)
                        target = 1;


Patches currently in longterm-queue-2.6.32 which might be from 
[email protected] are

/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/econet-4-byte-infoleak-to-the-network.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/drivers-rtc-rtc-ds1511.c-world-writable-sysfs-nvram-file.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/drivers-misc-ep93xx_pwm.c-world-writable-sysfs-files.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/bluetooth-bnep-fix-buffer-overflow.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/ipv6-netfilter-ip6_tables-fix-infoleak-to-userspace.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/mfd-ab3100-world-writable-debugfs-_priv-files.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/bridge-netfilter-fix-information-leak.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/netfilter-ip_tables-fix-infoleak-to-userspace.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/netfilter-ipt_clusterip-fix-buffer-overflow.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/netfilter-arp_tables-fix-infoleak-to-userspace.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/bluetooth-sco-fix-information-leak-to-userspace.patch

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to