This is a note to let you know that I've just added the patch titled
netfilter: arp_tables: fix infoleak to userspace
to the 2.6.32-longterm tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/longterm/longterm-queue-2.6.32.git;a=summary
The filename of the patch is:
netfilter-arp_tables-fix-infoleak-to-userspace.patch
and it can be found in the queue-2.6.32 subdirectory.
If you, or anyone else, feels it should not be added to the 2.6.32 longterm
tree,
please let <[email protected]> know about it.
>From 42eab94fff18cb1091d3501cd284d6bd6cc9c143 Mon Sep 17 00:00:00 2001
From: Vasiliy Kulikov <[email protected]>
Date: Tue, 15 Mar 2011 13:35:21 +0100
Subject: netfilter: arp_tables: fix infoleak to userspace
From: Vasiliy Kulikov <[email protected]>
commit 42eab94fff18cb1091d3501cd284d6bd6cc9c143 upstream.
Structures ipt_replace, compat_ipt_replace, and xt_get_revision are
copied from userspace. Fields of these structs that are
zero-terminated strings are not checked. When they are used as argument
to a format string containing "%s" in request_module(), some sensitive
information is leaked to userspace via argument of spawned modprobe
process.
The first bug was introduced before the git epoch; the second is
introduced by 6b7d31fc (v2.6.15-rc1); the third is introduced by
6b7d31fc (v2.6.15-rc1). To trigger the bug one should have
CAP_NET_ADMIN.
Signed-off-by: Vasiliy Kulikov <[email protected]>
Signed-off-by: Patrick McHardy <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/ipv4/netfilter/arp_tables.c | 3 +++
1 file changed, 3 insertions(+)
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -1086,6 +1086,7 @@ static int do_replace(struct net *net, v
/* overflow check */
if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;
newinfo = xt_alloc_table_info(tmp.size);
if (!newinfo)
@@ -1508,6 +1509,7 @@ static int compat_do_replace(struct net
return -ENOMEM;
if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;
newinfo = xt_alloc_table_info(tmp.size);
if (!newinfo)
@@ -1763,6 +1765,7 @@ static int do_arpt_get_ctl(struct sock *
ret = -EFAULT;
break;
}
+ rev.name[sizeof(rev.name)-1] = 0;
try_then_request_module(xt_find_revision(NFPROTO_ARP, rev.name,
rev.revision, 1, &ret),
Patches currently in longterm-queue-2.6.32 which might be from
[email protected] are
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/econet-4-byte-infoleak-to-the-network.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/drivers-rtc-rtc-ds1511.c-world-writable-sysfs-nvram-file.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/drivers-misc-ep93xx_pwm.c-world-writable-sysfs-files.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/bluetooth-bnep-fix-buffer-overflow.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/ipv6-netfilter-ip6_tables-fix-infoleak-to-userspace.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/mfd-ab3100-world-writable-debugfs-_priv-files.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/bridge-netfilter-fix-information-leak.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/netfilter-ip_tables-fix-infoleak-to-userspace.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/netfilter-ipt_clusterip-fix-buffer-overflow.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/netfilter-arp_tables-fix-infoleak-to-userspace.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.32/queue-2.6.32/bluetooth-sco-fix-information-leak-to-userspace.patch
_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable
