This is a note to let you know that I've just added the patch titled
netfilter: ip_tables: fix infoleak to userspace
to the 2.6.38-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netfilter-ip_tables-fix-infoleak-to-userspace.patch
and it can be found in the queue-2.6.38 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 78b79876761b86653df89c48a7010b5cbd41a84a Mon Sep 17 00:00:00 2001
From: Vasiliy Kulikov <[email protected]>
Date: Tue, 15 Mar 2011 13:36:05 +0100
Subject: netfilter: ip_tables: fix infoleak to userspace
From: Vasiliy Kulikov <[email protected]>
commit 78b79876761b86653df89c48a7010b5cbd41a84a upstream.
Structures ipt_replace, compat_ipt_replace, and xt_get_revision are
copied from userspace. Fields of these structs that are
zero-terminated strings are not checked. When they are used as argument
to a format string containing "%s" in request_module(), some sensitive
information is leaked to userspace via argument of spawned modprobe
process.
The first and the third bugs were introduced before the git epoch; the
second was introduced in 2722971c (v2.6.17-rc1). To trigger the bug
one should have CAP_NET_ADMIN.
Signed-off-by: Vasiliy Kulikov <[email protected]>
Signed-off-by: Patrick McHardy <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/ipv4/netfilter/ip_tables.c | 3 +++
1 file changed, 3 insertions(+)
--- a/net/ipv4/netfilter/ip_tables.c
+++ b/net/ipv4/netfilter/ip_tables.c
@@ -1261,6 +1261,7 @@ do_replace(struct net *net, const void _
/* overflow check */
if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;
newinfo = xt_alloc_table_info(tmp.size);
if (!newinfo)
@@ -1805,6 +1806,7 @@ compat_do_replace(struct net *net, void
return -ENOMEM;
if (tmp.num_counters >= INT_MAX / sizeof(struct xt_counters))
return -ENOMEM;
+ tmp.name[sizeof(tmp.name)-1] = 0;
newinfo = xt_alloc_table_info(tmp.size);
if (!newinfo)
@@ -2034,6 +2036,7 @@ do_ipt_get_ctl(struct sock *sk, int cmd,
ret = -EFAULT;
break;
}
+ rev.name[sizeof(rev.name)-1] = 0;
if (cmd == IPT_SO_GET_REVISION_TARGET)
target = 1;
Patches currently in stable-queue which might be from [email protected] are
queue-2.6.38/econet-4-byte-infoleak-to-the-network.patch
queue-2.6.38/scsi_transport_iscsi-make-priv_sess-file-writeable-only-by-root.patch
queue-2.6.38/drivers-leds-leds-lp5521.c-world-writable-sysfs-engine-files.patch
queue-2.6.38/drivers-rtc-rtc-ds1511.c-world-writable-sysfs-nvram-file.patch
queue-2.6.38/mfd-ab3500-world-writable-debugfs-register-files.patch
queue-2.6.38/drivers-misc-ep93xx_pwm.c-world-writable-sysfs-files.patch
queue-2.6.38/bluetooth-bnep-fix-buffer-overflow.patch
queue-2.6.38/ipv6-netfilter-ip6_tables-fix-infoleak-to-userspace.patch
queue-2.6.38/mfd-ab3100-world-writable-debugfs-_priv-files.patch
queue-2.6.38/bridge-netfilter-fix-information-leak.patch
queue-2.6.38/mfd-ab8500-world-writable-debugfs-register-files.patch
queue-2.6.38/netfilter-ip_tables-fix-infoleak-to-userspace.patch
queue-2.6.38/netfilter-ipt_clusterip-fix-buffer-overflow.patch
queue-2.6.38/drivers-leds-leds-lp5523.c-world-writable-engine-sysfs-files.patch
queue-2.6.38/netfilter-arp_tables-fix-infoleak-to-userspace.patch
queue-2.6.38/bluetooth-sco-fix-information-leak-to-userspace.patch
_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable
