On Wed, 20 Apr 2011 16:42:08 +0100, Chris Wilson <[email protected]> wrote: > Given that the hardware may be left in a random condition by the BIOS, > it is conceivable that we then attempt to clear the DP_PIPEB_SELECT bit > without us ever enabling/attaching the DP encoder to a pipe. Thus > causing a NULL deference when we attempt to wait for a vblank on that > crtc.
Is this because we're assuming that the only way DP_PIPEB_SELECT could have been set is by our driver? That does seem like a bad assumption on our part. > - intel_wait_for_vblank(dev, intel_crtc->pipe); > + intel_wait_for_crtc_vblank_safe(intel_dp->base.base.crtc); I actually think that simply placing the in-line function here in the code is clearer -- it makes it obvious that we aren't counting on there being a crtc assigned to this output. -- [email protected]
pgp5XFzjV6kYr.pgp
Description: PGP signature
_______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
