On Tue, 10 May 2011 11:09:54 +0100
Mel Gorman <[email protected]> wrote:

> include/linux/gfp.h and include/trace/events/gfpflags.h is out of
> sync. When tracing is enabled, certain flags are not recognised and
> the text output is less useful as a result.  Add the missing flags.
> 
> Signed-off-by: Mel Gorman <[email protected]>
> ---
>  include/trace/events/gfpflags.h |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/include/trace/events/gfpflags.h b/include/trace/events/gfpflags.h
> index e3615c0..9fe3a366 100644
> --- a/include/trace/events/gfpflags.h
> +++ b/include/trace/events/gfpflags.h
> @@ -10,6 +10,7 @@
>   */
>  #define show_gfp_flags(flags)                                                
> \
>       (flags) ? __print_flags(flags, "|",                             \
> +     {(unsigned long)GFP_TRANSHUGE,          "GFP_TRANSHUGE"},       \
>       {(unsigned long)GFP_HIGHUSER_MOVABLE,   "GFP_HIGHUSER_MOVABLE"}, \
>       {(unsigned long)GFP_HIGHUSER,           "GFP_HIGHUSER"},        \
>       {(unsigned long)GFP_USER,               "GFP_USER"},            \
> @@ -32,6 +33,9 @@
>       {(unsigned long)__GFP_HARDWALL,         "GFP_HARDWALL"},        \
>       {(unsigned long)__GFP_THISNODE,         "GFP_THISNODE"},        \
>       {(unsigned long)__GFP_RECLAIMABLE,      "GFP_RECLAIMABLE"},     \
> -     {(unsigned long)__GFP_MOVABLE,          "GFP_MOVABLE"}          \
> +     {(unsigned long)__GFP_MOVABLE,          "GFP_MOVABLE"},         \
> +     {(unsigned long)__GFP_NOTRACK,          "GFP_NOTRACK"},         \
> +     {(unsigned long)__GFP_NO_KSWAPD,        "GFP_NO_KSWAPD"},       \
> +     {(unsigned long)__GFP_OTHER_NODE,       "GFP_OTHER_NODE"}       \
>       ) : "GFP_NOWAIT"

The patch seems somewhat needed in 2.6.38.x, but 2.6.38 doesn't have
__GFP_OTHER_NODE.  So if you think this needs fixing in -stable, please
prepare a separate patch for that.

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to