i8k uses lahf to read the flag register in 64 bit code; early 64 bit CPUs, however, lack this instruction and we get an invalid opcode exception at runtime. Use pushf to load the flag register into the stack instead.
Signed-off-by: Luca Tettamanti <[email protected]> Reported-by: Jeff Rickman <[email protected]> Tested-by: Jeff Rickman <[email protected]> Tested-by: Harry G McGavran Jr <[email protected]> Cc: [email protected] --- drivers/char/i8k.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index d72433f..ee01716 100644 --- a/drivers/char/i8k.c +++ b/drivers/char/i8k.c @@ -139,8 +139,8 @@ static int i8k_smm(struct smm_regs *regs) "movl %%edi,20(%%rax)\n\t" "popq %%rdx\n\t" "movl %%edx,0(%%rax)\n\t" - "lahf\n\t" - "shrl $8,%%eax\n\t" + "pushfq\n\t" + "popq %%rax\n\t" "andl $1,%%eax\n" :"=a"(rc) : "a"(regs) _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
