On Fri, May 27, 2011 at 01:07:11PM +0200, Jean Delvare wrote: > On Fri, 27 May 2011 18:00:37 +0800, Greg KH wrote: > > On Fri, May 27, 2011 at 11:13:04AM +0200, Jean Delvare wrote: > > > Please consider including commit > > > 8fa0c9bf82b0b8697ace9532c5a50a0f4e0c7bb5 (gpiolib: export > > > gpiochip_find) in stable kernel series. While it doesn't fix a bug, it > > > will be required to build some drivers out-of-tree for older kernels. > > > > Hm, I really don't see the need to support out-of-tree drivers for older > > kernels as a need for the stable tree to pick stuff up. > > > > What drivers are out of tree that need this export? Why aren't they > > in-tree? > > The driver is i2c-i801, it is in the kernel tree, it doesn't currently > need gpiochip_find, but in 2.6.40 (I hope) it will have a new feature > which does require gpiochip_find. The idea is to let users of older > kernels pick i2c-i801 from 2.6.40 and build it out of tree for their > older kernel, if they are interested in the feature in question. > > Being able to point users to a standalone version of a given driver is > very convenient for testing purposes, I do it very frequently for hwmon > drivers.
I agree that it would be convenient, but I don't want to go adding exports to the kernel when there are no users of it for reasons that it doesn't match the existing stable kernel rules (i.e. it doesn't fix a bug.) So, sorry, I'll not be applying this. thanks, greg k-h _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
