On Tue, Jun 07, 2011 at 10:01:44AM -0700, [email protected] wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     drivers/base/platform.c: don't mark
> 
> to my driver-core git tree which can be found at
>     git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6.git
> in the driver-core-linus branch.
> 
> The patch will show up in the next release of the linux-next tree
> (usually sometime within the next 24 hours during the week.)
> 
> The patch will hopefully also will be merged in Linus's tree for the
> next -rc kernel release.
> 
> If you have any questions about this process, please let me know.
> 
> 
> From bb2b43fefab723f4a0760146e7bed59d41a50e53 Mon Sep 17 00:00:00 2001
> From: Andrew Morton <[email protected]>
> Date: Mon, 23 May 2011 14:44:19 -0700
> Subject: drivers/base/platform.c: don't mark
>  platform_device_register_resndata() as __init_or_module
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> This reverts 737a3bb9416ce2a7c7a4 ("Driver core: move platform device
> creation helpers to .init.text (if MODULE=n)").  That patch assumed that
> platform_device_register_resndata() is only ever called from __init code
> but that isn't true in the case ioctl->drm_ioctl->radeon_cp_init().
> 
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=35192
> 
> Cc: Uwe Kleine-König <[email protected]>
> Reported-by: Anthony Basile <[email protected]>
> Cc: Greg KH <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
>  drivers/base/platform.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 1c291af..6040717 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -367,7 +367,7 @@ EXPORT_SYMBOL_GPL(platform_device_unregister);
>   *
>   * Returns &struct platform_device pointer on success, or ERR_PTR() on error.
>   */
I'd like to have a comment here that says that there is only one user
that requires platform_device_register_resndata to be in .text and a
similar comment at the use. IIRC it was somewhere in the radeon driver.

Best regards
Uwe

> -struct platform_device *__init_or_module platform_device_register_resndata(
> +struct platform_device *platform_device_register_resndata(
>               struct device *parent,
>               const char *name, int id,
>               const struct resource *res, unsigned int num,

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to