Hello Jamie, On Tuesday 07 June 2011 11:58:47 Jamie Iles wrote: > On Thu, Jun 02, 2011 at 02:54:20PM +0200, Florian Fainelli wrote: > > Otherwise, the gpiolib autorequest feature will produce a WARN_ON(): > > > > WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c() > > autorequest GPIO-215 > > [...] > > > > CC: [email protected] > > Signed-off-by: Florian Fainelli <[email protected]> > > --- > > diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c > > index 63df28c..16086f8 100644 > > --- a/drivers/watchdog/mtx-1_wdt.c > > +++ b/drivers/watchdog/mtx-1_wdt.c > > @@ -214,6 +214,11 @@ static int __devinit mtx1_wdt_probe(struct > > platform_device *pdev) > > > > int ret; > > > > mtx1_wdt_device.gpio = pdev->resource[0].start; > > > > + ret = gpio_request(mtx1_wdt_device.gpio, "mtx1-wdt"); > > + if (ret < 0) { > > + dev_err(&pdev->dev, "failed to request gpio"); > > + return ret; > > + } > > Could you use gpio_request_one() here to make sure the GPIO is in the > correct direction first?
Makes sense, I will respin a v2 of these. -- Florian _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
