Fix the error handling in the EFIFB driver if platform_driver_probe() fails. In that case, the code will pass the driver struct to the _device_ unregistration function. It presumably should pass a pointer to the device struct instead.
The compiler gives the following warning to indicate this: drivers/video/efifb.c: In function 'efifb_init': drivers/video/efifb.c:544:3: warning: passing argument 1 of 'platform_device_unregister' from incompatible pointer type include/linux/platform_device.h:40:13: note: expected 'struct platform_device *' but argument is of type 'struct platform_driver *' Signed-off-by: David Howells <[email protected]> cc: Peter Jones <[email protected]> cc: [email protected] cc: [email protected] --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..784139a 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_device_unregister(&efifb_device); return ret; } _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
