commit: 384420409d9b5d4443940abace49363d26135412 From: Richard Cochran <[email protected]> Date: Sun, 19 Jun 2011 21:48:06 +0000 Subject: [PATCH] pxa168_eth: fix race in transmit path.
Because the socket buffer is freed in the completion interrupt, it is not safe to access it after submitting it to the hardware. Cc: [email protected] Cc: Sachin Sanap <[email protected]> Cc: Zhangfei Gao <[email protected]> Cc: Philip Rakity <[email protected]> Signed-off-by: Richard Cochran <[email protected]> Acked-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]> --- drivers/net/pxa168_eth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/pxa168_eth.c b/drivers/net/pxa168_eth.c index 89f7540..5f597ca 100644 --- a/drivers/net/pxa168_eth.c +++ b/drivers/net/pxa168_eth.c @@ -1273,7 +1273,7 @@ static int pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev) wmb(); wrl(pep, SDMA_CMD, SDMA_CMD_TXDH | SDMA_CMD_ERD); - stats->tx_bytes += skb->len; + stats->tx_bytes += length; stats->tx_packets++; dev->trans_start = jiffies; if (pep->tx_ring_size - pep->tx_desc_count <= 1) { _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
