ACK.

> -----Original Message-----
> From: Greg KH [mailto:[email protected]]
> Sent: Friday, July 08, 2011 5:46 AM
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected]; akpm@linux-
> foundation.org; [email protected]; Sachin Sanap; Zhangfei Gao;
> Philip Rakity; Richard Cochran; Eric Dumazet; David S. Miller
> Subject: [047/107] pxa168_eth: fix race in transmit path.
> 
> 2.6.39-stable review patch.  If anyone has any objections, please let us
> know.
> 
> ------------------
> 
> From: Richard Cochran <[email protected]>
> 
> commit 384420409d9b5d4443940abace49363d26135412 upstream.
> 
> Because the socket buffer is freed in the completion interrupt, it is not
> safe to access it after submitting it to the hardware.
> 
> Cc: Sachin Sanap <[email protected]>
> Cc: Zhangfei Gao <[email protected]>
> Cc: Philip Rakity <[email protected]>
> Signed-off-by: Richard Cochran <[email protected]>
> Acked-by: Eric Dumazet <[email protected]>
> Signed-off-by: David S. Miller <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> 
> ---
>  drivers/net/pxa168_eth.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/net/pxa168_eth.c
> +++ b/drivers/net/pxa168_eth.c
> @@ -1273,7 +1273,7 @@ static int pxa168_eth_start_xmit(struct
>       wmb();
>       wrl(pep, SDMA_CMD, SDMA_CMD_TXDH | SDMA_CMD_ERD);
> 
> -     stats->tx_bytes += skb->len;
> +     stats->tx_bytes += length;
>       stats->tx_packets++;
>       dev->trans_start = jiffies;
>       if (pep->tx_ring_size - pep->tx_desc_count <= 1) {
> 


_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to