2.6.27-longterm review patch. If anyone has any objections, please let us know.
------------------ commit cced5041ed5a2d1352186510944b0ddfbdbe4c0b upstream. sym53c8xx_slave_destroy unconditionally assumes that sym53c8xx_slave_alloc has succesesfully allocated a sym_lcb. This can lead to a NULL pointer dereference (exposed by commit 4e6c82b). Signed-off-by: Stratos Psomadakis <[email protected]> Signed-off-by: James Bottomley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) Index: longterm-2.6.27/drivers/scsi/sym53c8xx_2/sym_glue.c =================================================================== --- longterm-2.6.27.orig/drivers/scsi/sym53c8xx_2/sym_glue.c 2012-02-05 22:34:32.760914610 +0100 +++ longterm-2.6.27/drivers/scsi/sym53c8xx_2/sym_glue.c 2012-02-05 22:34:45.383915058 +0100 @@ -821,6 +821,10 @@ struct sym_hcb *np = sym_get_hcb(sdev->host); struct sym_lcb *lp = sym_lp(&np->target[sdev->id], sdev->lun); + /* if slave_alloc returned before allocating a sym_lcb, return */ + if (!lp) + return; + if (lp->itlq_tbl) sym_mfree_dma(lp->itlq_tbl, SYM_CONF_MAX_TASK * 4, "ITLQ_TBL"); kfree(lp->cb_tags); -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
