On Tue 21-02-12 04:14:50, Namjae Jeon wrote: > 2012/2/21 Jan Kara <[email protected]>: > > udf_release_file() can be called from munmap() path with mmap_sem held. > > Thus > > we cannot take i_mutex there because that ranks above mmap_sem. Luckily, > > i_mutex is not needed in udf_release_file() anymore since protection by > > i_data_sem is enough to protect from races with write and truncate. > > > > Reported-by: Al Viro <[email protected]> > > Signed-off-by: Jan Kara <[email protected]> > HI. Jan. > Looks reasonable to me. And I think that this patch should be added in > stable kernel. > So I add cc: [email protected]. Good point. Added.
> Reviewed-by: Namjae Jeon <[email protected]> Thanks. Honza > > --- > > fs/udf/file.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > If noone objects, I will add this patch to my tree and push it to Linus. > > > > diff --git a/fs/udf/file.c b/fs/udf/file.c > > index dca0c38..d567b84 100644 > > --- a/fs/udf/file.c > > +++ b/fs/udf/file.c > > @@ -201,12 +201,10 @@ out: > > static int udf_release_file(struct inode *inode, struct file *filp) > > { > > if (filp->f_mode & FMODE_WRITE) { > > - mutex_lock(&inode->i_mutex); > > down_write(&UDF_I(inode)->i_data_sem); > > udf_discard_prealloc(inode); > > udf_truncate_tail_extent(inode); > > up_write(&UDF_I(inode)->i_data_sem); > > - mutex_unlock(&inode->i_mutex); > > } > > return 0; > > } > > -- > > 1.7.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > > the body of a message to [email protected] > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara <[email protected]> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
