On Wed, Feb 22, 2012 at 03:46:10PM -0800, Tim Gardner wrote: > On 02/21/2012 10:33 AM, Greg KH wrote: > >On Fri, Feb 17, 2012 at 06:49:52AM -0700, Tim Gardner wrote: > >>From: Andy Whitcroft<[email protected]> > >> > >>read() calls against a file descriptor connected to a directory are > >>incorrectly returning EINVAL rather than EISDIR: > >> > >> [EISDIR] > >> [XSI] [Option Start] The fildes argument refers to a directory and the > >> implementation does not allow the directory to be read using read() > >> or pread(). The readdir() function should be used instead. [Option End] > >> > >>This occurs because we do not have a .read operation defined for > >>ecryptfs directories. Connect this up to generic_read_dir(). > >> > >>BugLink: http://bugs.launchpad.net/bugs/719691 > >>Signed-off-by: Andy Whitcroft<[email protected]> > >>Signed-off-by: Tyler Hicks<[email protected]> > >> > >>(cherry picked from commit 323ef68faf1bbd9b1e66aea268fd09d358d7e8ab) > >>Cc: Tyler Hicks<[email protected]> > >>Signed-off-by: Colin Ian King<[email protected]> > >>Signed-off-by: Tim Gardner<[email protected]> > > > >Why did you drop Andy's original signed-off-by for this patch? And > >Tyler's? > > > >Again, not acceptable at all, if you are going to make me verify every > >patch you send, as being correct, I'm just not going to anymore, as it's > >a waste of my time, don't you agree? > > > >I'll apply Andy's original patch here, as I already did the research for > >it, but that's it, if you want anything else applied, please resend it > >_AFTER_ verifying that you didn't strip any credits out of it. > > > >greg k-h > > I'm not grok'ing what you think is wrong. Andy's s-o-b looks like > its there to me. Everything below the 'cherry picked' line > references everyone that participated in the bug fix. I've noted > Tyler's new email address, Colin selected this patch for application > and testing, and I was the final sign-off for the Ubuntu kernel.
Sorry, you are right, I didn't notice it above the extra line. Staring at patches all day causes you to go blind at times, your brain does pattern matching and when something shows up that is different from normal, it doesn't always catch it. My apologies. greg "my brain needs help" k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
