This is a note to let you know that I've just added the patch titled

    i387: fix sense of sanity check

to the 3.0-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     i387-fix-sense-of-sanity-check.patch
and it can be found in the queue-3.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From c38e23456278e967f094b08247ffc3711b1029b2 Mon Sep 17 00:00:00 2001
From: Linus Torvalds <[email protected]>
Date: Wed, 15 Feb 2012 08:05:18 -0800
Subject: i387: fix sense of sanity check

From: Linus Torvalds <[email protected]>

commit c38e23456278e967f094b08247ffc3711b1029b2 upstream.

The check for save_init_fpu() (introduced in commit 5b1cbac37798: "i387:
make irq_fpu_usable() tests more robust") was the wrong way around, but
I hadn't noticed, because my "tests" were bogus: the FPU exceptions are
disabled by default, so even doing a divide by zero never actually
triggers this code at all unless you do extra work to enable them.

So if anybody did enable them, they'd get one spurious warning.

Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 arch/x86/include/asm/i387.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/include/asm/i387.h
+++ b/arch/x86/include/asm/i387.h
@@ -404,7 +404,7 @@ static inline void irq_ts_restore(int TS
  */
 static inline void save_init_fpu(struct task_struct *tsk)
 {
-       WARN_ON_ONCE(task_thread_info(tsk)->status & TS_USEDFPU);
+       WARN_ON_ONCE(!(task_thread_info(tsk)->status & TS_USEDFPU));
        preempt_disable();
        __save_init_fpu(tsk);
        stts();


Patches currently in stable-queue which might be from 
[email protected] are

queue-3.0/i387-fix-sense-of-sanity-check.patch
queue-3.0/i387-move-ts_usedfpu-clearing-out-of-__save_init_fpu-and-into-callers.patch
queue-3.0/i387-math_state_restore-isn-t-called-from-asm.patch
queue-3.0/i387-fix-x86-64-preemption-unsafe-user-stack-save-restore.patch
queue-3.0/i387-do-not-preload-fpu-state-at-task-switch-time.patch
queue-3.0/i387-make-irq_fpu_usable-tests-more-robust.patch
queue-3.0/i387-don-t-ever-touch-ts_usedfpu-directly-use-helper-functions.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to