For the patch below, what are the "real world use cases" that would
cause this to be needed in the stable kernel trees?  Is there an
in-kernel module that is affected by this limitation?

Also, when was "a while ago" exactly?

thanks,

greg k-h


On Wed, Mar 28, 2012 at 06:01:21PM -0400, Gregs git-bot wrote:
> commit: f946eeb9313ff1470758e171a60fe7438a2ded3f
> From: Sasha Levin <[email protected]>
> Date: Mon, 30 Jan 2012 23:07:22 -0500
> Subject: module: Remove module size limit
> 
> Module size was limited to 64MB, this was legacy limitation due to vmalloc()
> which was removed a while ago.
> 
> Limiting module size to 64MB is both pointless and affects real world use
> cases.
> 
> Cc: Tim Abbott <[email protected]>
> Cc: [email protected]
> Signed-off-by: Sasha Levin <[email protected]>
> Signed-off-by: Rusty Russell <[email protected]>
> ---
>  kernel/module.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 294692d..78ac6ec 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2411,8 +2411,7 @@ static int copy_and_check(struct load_info *info,
>               return -ENOEXEC;
>  
>       /* Suck in entire file: we'll want most of it. */
> -     /* vmalloc barfs on "unusual" numbers.  Check here */
> -     if (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) == NULL)
> +     if ((hdr = vmalloc(len)) == NULL)
>               return -ENOMEM;
>  
>       if (copy_from_user(hdr, umod, len) != 0) {
> -- 
> 1.7.3.4
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to