This is a note to let you know that I've just added the patch titled

    lockd: fix arg parsing for grace_period and timeout.

to the 3.3-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     lockd-fix-arg-parsing-for-grace_period-and-timeout.patch
and it can be found in the queue-3.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From de5b8e8e047534aac6bc9803f96e7257436aef9c Mon Sep 17 00:00:00 2001
From: NeilBrown <[email protected]>
Date: Tue, 7 Feb 2012 15:35:42 +1100
Subject: lockd: fix arg parsing for grace_period and timeout.

From: NeilBrown <[email protected]>

commit de5b8e8e047534aac6bc9803f96e7257436aef9c upstream.

If you try to set grace_period or timeout via a module parameter
to lockd, and do this on a big-endian machine where

   sizeof(int) != sizeof(unsigned long)

it won't work.  This number given will be effectively shifted right
by the difference in those two sizes.

So cast kp->arg properly to get correct result.

Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: J. Bruce Fields <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 fs/lockd/svc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -440,7 +440,7 @@ static int param_set_##name(const char *
        __typeof__(type) num = which_strtol(val, &endp, 0);             \
        if (endp == val || *endp || num < (min) || num > (max))         \
                return -EINVAL;                                         \
-       *((int *) kp->arg) = num;                                       \
+       *((type *) kp->arg) = num;                                      \
        return 0;                                                       \
 }
 


Patches currently in stable-queue which might be from [email protected] are

queue-3.3/lockd-fix-arg-parsing-for-grace_period-and-timeout.patch
queue-3.3/md-raid1-raid10-avoid-deadlock-during-resync-recovery.patch
queue-3.3/md-bitmap-ensure-to-load-bitmap-when-creating-via-sysfs.patch
queue-3.3/md-fix-clearing-of-the-changed-flags-for-the-bad-blocks-list.patch
queue-3.3/md-don-t-set-md-arrays-to-readonly-on-shutdown.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to