Hi Greg,

Do you find issues with this patch?

Thanks
Kishon

On Wed, Mar 28, 2012 at 11:24 AM, Kishon Vijay Abraham I <[email protected]> wrote:
> commit 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026 "usb: musb: Idle path
> retention and offmode support for OMAP3" makes pm_runtime_enable to be
> called after omap2430_musb_init. Hence pm_runtime_get_sync in
> omap2430_musb_init does not have any effect (does not enable clocks)
> resulting in abort during register access. It is fixed here.
>
> Cc: [email protected] # 3.0.y, 3.1.y, 3.2.y
> Cc: Hema HK <[email protected]>
> Cc: Felipe Balbi <[email protected]>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> Changes from V1:
>        Changed the commit log section
> Boot test and tested for g_zero enumeration (MUSB) in omap4SDP
>  drivers/usb/musb/omap2430.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 2ae0bb3..73bd5ed 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -452,14 +452,14 @@ static int __devinit omap2430_probe(struct 
> platform_device *pdev)
>                goto err2;
>        }
>
> +       pm_runtime_enable(&pdev->dev);
> +
>        ret = platform_device_add(musb);
>        if (ret) {
>                dev_err(&pdev->dev, "failed to register musb device\n");
>                goto err2;
>        }
>
> -       pm_runtime_enable(&pdev->dev);
> -
>        return 0;
>
>  err2:
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to