This is a note to let you know that I've just added the patch titled
rose_dev: fix memcpy-bug in rose_set_mac_address
to the 3.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rose_dev-fix-memcpy-bug-in-rose_set_mac_address.patch
and it can be found in the queue-3.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From f2a6217bccca34c7c124dcdb24ca3f21f49cd168 Mon Sep 17 00:00:00 2001
From: "danborkm...@iogearbox.net" <danborkm...@iogearbox.net>
Date: Tue, 27 Mar 2012 22:47:43 +0000
Subject: rose_dev: fix memcpy-bug in rose_set_mac_address
From: "danborkm...@iogearbox.net" <danborkm...@iogearbox.net>
[ Upstream commit 81213b5e8ae68e204aa7a3f83c4f9100405dbff9 ]
If both addresses equal, nothing needs to be done. If the device is down,
then we simply copy the new address to dev->dev_addr. If the device is up,
then we add another loopback device with the new address, and if that does
not fail, we remove the loopback device with the old address. And only
then, we update the dev->dev_addr.
Signed-off-by: Daniel Borkmann <daniel.borkm...@tik.ee.ethz.ch>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
net/rose/rose_dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/net/rose/rose_dev.c
+++ b/net/rose/rose_dev.c
@@ -96,11 +96,11 @@ static int rose_set_mac_address(struct n
struct sockaddr *sa = addr;
int err;
- if (!memcpy(dev->dev_addr, sa->sa_data, dev->addr_len))
+ if (!memcmp(dev->dev_addr, sa->sa_data, dev->addr_len))
return 0;
if (dev->flags & IFF_UP) {
- err = rose_add_loopback_node((rose_address *)dev->dev_addr);
+ err = rose_add_loopback_node((rose_address *)sa->sa_data);
if (err)
return err;
Patches currently in stable-queue which might be from danborkm...@iogearbox.net
are
queue-3.2/rose_dev-fix-memcpy-bug-in-rose_set_mac_address.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
