On 12-04-16 03:44 PM, John Stultz wrote: > On 04/16/2012 07:23 AM, richard -rw- weinberger wrote: >> On Mon, Apr 16, 2012 at 3:55 PM, Mark Lord<[email protected]> wrote: >>> Speaking of which -- that batch of RTC updates is riddled with bugs. >>> For example, this beauty from rtc-mpc5121.c in the same update: >>> >>> ... >>> rtc->rtc = rtc_device_register("mpc5200-rtc",&op->dev, >>> &mpc5200_rtc_ops, THIS_MODULE); >>> ... >>> >>> rtc->rtc->uie_unsupported = 1; //<<<< Ooops NULL pointer>>>> >>> >>> if (IS_ERR(rtc->rtc)) { //<<<< this needs to be >>> earlier>>>> >>> err = PTR_ERR(rtc->rtc); >>> goto out_free_irq; >>> } >>> ... >>> >>> > > Thanks for noticing this and CC'ing me. I'll spin up a fix promptly for > review. > -john
Yeah. My apologies for being so harsh there. At least the fix is easy enough. Cheers! -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
