Hi Kevin, Thanks for the review. On Wednesday 18 April 2012 05:36 AM, Kevin Hilman wrote: > Shubhrajyoti D <[email protected]> writes: > >> In the error cases the clock cut is missed. This patch intends to fix the >> same. > Please change the references to 'cut clocks' in subject/changelog here > (and in other patches) to use runtime suspend instead. First, runtime PM > calls do more than cut clocks, but they only do so when > usecounting/autosuspend timeouts permit. Yes thanks will fix it. > > >> Cc: [email protected] > Please hold off on Cc'ing stable until your patches are reviewed and accepted. OK >> Cc: Govindraj.R <[email protected]> >> Signed-off-by: Shubhrajyoti D <[email protected]> >> --- >> drivers/tty/serial/omap-serial.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/tty/serial/omap-serial.c >> b/drivers/tty/serial/omap-serial.c >> index fe099bb..10e80bb 100644 >> --- a/drivers/tty/serial/omap-serial.c >> +++ b/drivers/tty/serial/omap-serial.c >> @@ -319,6 +319,8 @@ static void serial_omap_start_tx(struct uart_port *port) >> >> if (ret < 0) { >> serial_omap_enable_ier_thri(up); >> + pm_runtime_mark_last_busy(&up->pdev->dev); >> + pm_runtime_put_autosuspend(&up->pdev->dev); > Why the autosuspend version here? > > Kevin > > In case the request_dma fails we enable the thri( effectively like intr mode) so I thought of using the autosuspend version here .
Do you prefer put version instead ? With Regards, Shubhro -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
