This is a note to let you know that I've just added the patch titled
usb: gadget: pch_udc: Fix wrong return value
to the 3.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-gadget-pch_udc-fix-wrong-return-value.patch
and it can be found in the queue-3.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From c802672cd36cd063bfd54d54c8c34825ab5b2357 Mon Sep 17 00:00:00 2001
From: Tomoya MORINAGA <[email protected]>
Date: Thu, 12 Jan 2012 11:27:06 +0900
Subject: usb: gadget: pch_udc: Fix wrong return value
From: Tomoya MORINAGA <[email protected]>
commit c802672cd36cd063bfd54d54c8c34825ab5b2357 upstream.
ISSUE:
If the return value of pch_udc_pcd_init() is False, the return value of
this function is unsettled.
Since pch_udc_pcd_init() always returns 0, there is not actually the issue.
CAUSE:
If pch_udc_pcd_init() is True, the variable, retval, is not set for an
appropriate value.
Signed-off-by: Tomoya MORINAGA <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/usb/gadget/pch_udc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/usb/gadget/pch_udc.c
+++ b/drivers/usb/gadget/pch_udc.c
@@ -2915,8 +2915,10 @@ static int pch_udc_probe(struct pci_dev
}
pch_udc = dev;
/* initialize the hardware */
- if (pch_udc_pcd_init(dev))
+ if (pch_udc_pcd_init(dev)) {
+ retval = -ENODEV;
goto finished;
+ }
if (request_irq(pdev->irq, pch_udc_isr, IRQF_SHARED, KBUILD_MODNAME,
dev)) {
dev_err(&pdev->dev, "%s: request_irq(%d) fail\n", __func__,
Patches currently in stable-queue which might be from [email protected] are
queue-3.2/usb-gadget-pch_udc-fix-usb-suspend-issue.patch
queue-3.2/pch_uart-fix-msi-setting-issue.patch
queue-3.2/gpio-add-missing-spin_lock_init-in-gpio-pch-driver.patch
queue-3.2/usb-gadget-pch_udc-fix-wrong-return-value.patch
queue-3.2/usb-gadget-pch_udc-fix-usb-gadget-pch_udc-fix-ether.patch
queue-3.2/usb-gadget-pch_udc-fix-disconnect-issue.patch
queue-3.2/usb-gadget-pch_udc-reduce-redundant-interrupt.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
