This is a note to let you know that I've just added the patch titled
usb: gadget: pch_udc: Reduce redundant interrupt
to the 3.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-gadget-pch_udc-reduce-redundant-interrupt.patch
and it can be found in the queue-3.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 833310402c54ad9b676b465fc53ad276b13d36be Mon Sep 17 00:00:00 2001
From: Tomoya MORINAGA <[email protected]>
Date: Thu, 12 Jan 2012 11:27:09 +0900
Subject: usb: gadget: pch_udc: Reduce redundant interrupt
From: Tomoya MORINAGA <[email protected]>
commit 833310402c54ad9b676b465fc53ad276b13d36be upstream.
ISSUE:
USB Suspend interrupts occur frequently.
CAUSE:
When it is called pch_udc_reconnect() in USB Suspend, it repeats reset and
Suspend.
SOLUTION:
pch_udc_reconnect() does not enable all interrupts. When an enumeration event
occurred the driver enables all interrupts.
Signed-off-by: Tomoya MORINAGA <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/usb/gadget/pch_udc.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
--- a/drivers/usb/gadget/pch_udc.c
+++ b/drivers/usb/gadget/pch_udc.c
@@ -568,9 +568,7 @@ static void pch_udc_reconnect(struct pch
/* enable device interrupts */
/* pch_udc_enable_interrupts() */
pch_udc_bit_clr(dev, UDC_DEVIRQMSK_ADDR,
- UDC_DEVINT_UR | UDC_DEVINT_US |
- UDC_DEVINT_ENUM |
- UDC_DEVINT_SI | UDC_DEVINT_SC);
+ UDC_DEVINT_UR | UDC_DEVINT_ENUM);
/* Clear the disconnect */
pch_udc_bit_set(dev, UDC_DEVCTL_ADDR, UDC_DEVCTL_RES);
@@ -2419,6 +2417,11 @@ static void pch_udc_svc_enum_interrupt(s
pch_udc_set_dma(dev, DMA_DIR_TX);
pch_udc_set_dma(dev, DMA_DIR_RX);
pch_udc_ep_set_rrdy(&(dev->ep[UDC_EP0OUT_IDX]));
+
+ /* enable device interrupts */
+ pch_udc_enable_interrupts(dev, UDC_DEVINT_UR | UDC_DEVINT_US |
+ UDC_DEVINT_ES | UDC_DEVINT_ENUM |
+ UDC_DEVINT_SI | UDC_DEVINT_SC);
}
/**
Patches currently in stable-queue which might be from [email protected] are
queue-3.2/usb-gadget-pch_udc-fix-usb-suspend-issue.patch
queue-3.2/pch_uart-fix-msi-setting-issue.patch
queue-3.2/gpio-add-missing-spin_lock_init-in-gpio-pch-driver.patch
queue-3.2/usb-gadget-pch_udc-fix-wrong-return-value.patch
queue-3.2/usb-gadget-pch_udc-fix-usb-gadget-pch_udc-fix-ether.patch
queue-3.2/usb-gadget-pch_udc-fix-disconnect-issue.patch
queue-3.2/usb-gadget-pch_udc-reduce-redundant-interrupt.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html