[email protected] wrote:

This is a note to let you know that I've just added the patch titled

     md: don't call ->add_disk unless there is good reason.

to the 3.3-stable tree which can be found at:
     
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
      md-don-t-call-add_disk-unless-there-is-good-reason.patch
and it can be found in the queue-3.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let<[email protected]>  know about it.

No objections. In fact,

Tested-by: Jan Ceuleers <[email protected]>

(but don't bother adding that if it's manual work)

From ed209584c38fb74b7eecc03e5b1bfe674e591bd8 Mon Sep 17 00:00:00 2001
From: NeilBrown<[email protected]>
Date: Tue, 24 Apr 2012 10:23:14 +1000
Subject: md: don't call ->add_disk unless there is good reason.

From: NeilBrown<[email protected]>

commit ed209584c38fb74b7eecc03e5b1bfe674e591bd8 upstream.

Commit 7bfec5f35c68121e7b18

    md/raid5: If there is a spare and a want_replacement device, start 
replacement.

cause md_check_recovery to call ->add_disk much more often.
Instead of only when the array is degraded, it is now called whenever
md_check_recovery finds anything useful to do, which includes
updating the metadata for clean<->dirty transition.
This causes unnecessary work, and causes info messages from ->add_disk
to be reported much too often.

So refine md_check_recovery to only do any actual recovery checking
(including ->add_disk) if MD_RECOVERY_NEEDED is set.

This fix is suitable for 3.3.y:

Reported-by: Jan Ceuleers<[email protected]>
Signed-off-by: NeilBrown<[email protected]>
Signed-off-by: Greg Kroah-Hartman<[email protected]>

Thanks, Jan
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to