From: Ben Hutchings <[email protected]> Date: Sat, 12 May 2012 10:16:25 +0100
>> @@ -269,4 +269,4 @@ static int __init sunfire_init(void) >> return 0; >> } >> >> -subsys_initcall(sunfire_init); >> +fs_initcall(sunfire_init); > [...] > > Your commit message didn't mention the init order change; is that > needed/safe in 3.2.y? Unintended, albeit correct, change in the commit and it made it into Linus's tree as well. The change is correct, I wanted to make sure all openfirmware device drivers get done late enough, subsys_initcall() is too early. This is related to: commit 9e0daff30fd7ecf698e5d20b0fa7f851e427cca5 Author: David S. Miller <[email protected]> Date: Fri Apr 13 11:56:22 2012 -0700 sparc64: Fix bootup crash on sun4v. The DS driver registers as a subsys_initcall() but this can be too early, in particular this risks registering before we've had a chance to allocate and setup module_kset in kernel/params.c which is performed also as a subsyts_initcall(). Register DS using device_initcall() insteal. Signed-off-by: David S. Miller <[email protected]> Cc: [email protected] diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c index fea13c7..b93c2c9 100644 --- a/arch/sparc/kernel/ds.c +++ b/arch/sparc/kernel/ds.c @@ -1264,4 +1264,4 @@ static int __init ds_init(void) return vio_register_driver(&ds_driver); } -subsys_initcall(ds_init); +fs_initcall(ds_init); -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
