On Sun, May 27, 2012 at 09:20:10AM +0900, [email protected] wrote: > > This is a note to let you know that I've just added the patch titled > > ARM: 7365/1: drop unused parameter from flush_cache_user_range > > to the 3.4-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > arm-7365-1-drop-unused-parameter-from-flush_cache_user_range.patch > and it can be found in the queue-3.4 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <[email protected]> know about it. I'm pretty sure the patch won't hurt, but I doubt if it's worth to include it in stable because it's only a cosmetic change. The best argument I see is, that it might make backporting of other patches easier. I didn't check, but I'd be surprised if there were a new caller?!
Best regards Uwe > From 4542b6a0fa6b48d9ae6b41c1efeb618b7a221b2a Mon Sep 17 00:00:00 2001 > From: Dima Zavin <[email protected]> > Date: Thu, 29 Mar 2012 20:44:06 +0100 > Subject: ARM: 7365/1: drop unused parameter from flush_cache_user_range > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > From: Dima Zavin <[email protected]> > > commit 4542b6a0fa6b48d9ae6b41c1efeb618b7a221b2a upstream. > > vma isn't used and flush_cache_user_range isn't a standard macro that > is used on several archs with the same prototype. In fact only unicore32 > has a macro with the same name (with an identical implementation and no > in-tree users). > > This is a part of a patch proposed by Dima Zavin (with Message-id: > [email protected]) that didn't get > accepted. > > Cc: Dima Zavin <[email protected]> > Acked-by: Catalin Marinas <[email protected]> > Signed-off-by: Uwe Kleine-K??nig <[email protected]> > Signed-off-by: Russell King <[email protected]> > Cc: Will Deacon <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > > --- > arch/arm/include/asm/cacheflush.h | 2 +- > arch/arm/kernel/traps.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > --- a/arch/arm/include/asm/cacheflush.h > +++ b/arch/arm/include/asm/cacheflush.h > @@ -249,7 +249,7 @@ extern void flush_cache_page(struct vm_a > * Harvard caches are synchronised for the user space address range. > * This is used for the ARM private sys_cacheflush system call. > */ > -#define flush_cache_user_range(vma,start,end) \ > +#define flush_cache_user_range(start,end) \ > __cpuc_coherent_user_range((start) & PAGE_MASK, PAGE_ALIGN(end)) > > /* > --- a/arch/arm/kernel/traps.c > +++ b/arch/arm/kernel/traps.c > @@ -496,7 +496,7 @@ do_cache_op(unsigned long start, unsigne > if (end > vma->vm_end) > end = vma->vm_end; > > - flush_cache_user_range(vma, start, end); > + flush_cache_user_range(start, end); > } > up_read(&mm->mmap_sem); > } > > > Patches currently in stable-queue which might be from [email protected] are > > queue-3.4/arm-7409-1-do-not-call-flush_cache_user_range-with-mmap_sem-held.patch > queue-3.4/arm-7365-1-drop-unused-parameter-from-flush_cache_user_range.patch > -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
