On Thu, Jun 07, 2012 at 01:12:56AM -0500, Jonathan Nieder wrote: > Hi Richard, > > Richard Yao wrote: > > > This is my first time patch submission. The commit message should > > explain the issue. > > > > commit ba8c7a7a629b736fdc1abceaa3ec49f8820aec08 > > Author: Richard Yao <[email protected]> > > Date: Thu Jun 7 01:44:31 2012 -0400 > > > > scsi: lpfc_scsi: Remove unused variables > > > > Kernels built with CONFIG_SCSI_LPFC fail to compile due to the use of > > -Werror=unused-variable. We solve that by removing some unused > > variables. > > Wouldn't a saner fix be to stop using -Werror=unused-variable, or am I > missing something subtle?
Yes, that is correct, older versions of gcc, and sometimes newer ones, get this logic wrong and incorrectly flag variables that really are used due to bugs in their detection logic. Don't require a developer to have a gcc version that is different from what the rest of the kernel requires, as that is not allowed. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
