On Thu, Jun 07, 2012 at 01:11:20PM +0200, Linus Walleij wrote: > <[email protected]> wrote:
> > + ? ? ? if (value) > > + ? ? ? ? ? ? ? value = WM8994_GPN_LVL; > > ? ? ? ?return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset, > > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?WM8994_GPN_DIR, 0); > > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?WM8994_GPN_DIR | WM8994_GPN_LVL, value); > > ?} > The commit message is so terse compared to what the code does that > I cannot claim to understand what this patch is doing. > Could you elaborate on the problem ans symptoms, just for a nice > commit log? I'm not really sure what more there is to say... previously we were ignoring the value that's set as part of setting output mode so if someone wanted to set a value different to the one the chip happened to have that wouldn't happen. Ignoring the vaue that the user is trying to set seems like an obvious enough bug in itself. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
