On Thu, Jun 14, 2012 at 08:49:35AM -0700, Greg KH wrote: > On Thu, Jun 14, 2012 at 07:55:07AM -0500, Dimitri Sivanich wrote: > > Could commit a841f8cef4bb124f0f5563314d0beaf2e1249d72 be added to the > > stable tree? > > For which stable tree?
3.0 and 3.4, sorry about that. > > > http://git2.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=a841f8cef4bb124f0f5563314d0beaf2e1249d72 > > Any reason you didn't cc: the other people who signed-off that patch? Laziness :) Also, here is a version backported to 3.0. Fix the relax_domain_level boot parameter. It does not get processed because sched_domain_level_max is 0 at the time that setup_relax_domain_level() is run. Simply accept the value as it is, as we don't know the value of sched_domain_level_max until sched domain construction is completed. Fix sched_relax_domain_level in cpuset. The build_sched_domain() routine calls the set_domain_attribute() routine prior to setting the sd->level, however, the set_domain_attribute() routine relies on the sd->level to decide whether idle load balancing will be off/on. Signed-off-by: Dimitri Sivanich <[email protected]> --- kernel/sched.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) Index: linux/kernel/sched.c =================================================================== --- linux.orig/kernel/sched.c +++ linux/kernel/sched.c @@ -7519,11 +7519,8 @@ int sched_domain_level_max; static int __init setup_relax_domain_level(char *str) { - unsigned long val; - - val = simple_strtoul(str, NULL, 0); - if (val < sched_domain_level_max) - default_relax_domain_level = val; + if (kstrtoint(str, 0, &default_relax_domain_level)) + pr_warn("Unable to set relax_domain_level\n"); return 1; } @@ -7716,7 +7713,6 @@ struct sched_domain *build_sched_domain( if (!sd) return child; - set_domain_attribute(sd, attr); cpumask_and(sched_domain_span(sd), cpu_map, tl->mask(cpu)); if (child) { sd->level = child->level + 1; @@ -7724,6 +7720,7 @@ struct sched_domain *build_sched_domain( child->parent = sd; } sd->child = child; + set_domain_attribute(sd, attr); return sd; } -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
