Tested this modification on MX28 hardware that I have access to. With
this patch I can now create UBI file system on flash.
Tested-by: snijs...@grid-net.com
Thanks!
-Subodh
On 06/26/2012 08:26 AM, Sascha Hauer wrote:
The gpmi-nand driver uses virt_addr_valid() to check whether a buffer
is suitable for dma. If it's not, a driver allocated buffer is used
instead. Then after a page read the driver allocated buffer must be
copied to the user supplied buffer. This does not happen since:
commit 7725cc85932bd02dd12c23108e0ef748c551ccba
Author: Brian Norris <computersforpe...@gmail.com>
Date: Wed May 2 10:15:02 2012 -0700
mtd: gpmi-nand: utilize oob_requested parameter
Don't read OOB if the caller didn't request it.
Signed-off-by: Brian Norris <computersforpe...@gmail.com>
Acked-by: Huang Shijie <b32...@freescale.com>
Signed-off-by: Artem Bityutskiy <artem.bityuts...@linux.intel.com>
Signed-off-by: David Woodhouse <david.woodho...@intel.com>
This patch fixes this. The bug is encountered with UBI which uses a vmalloced
buffer for the volume table.
Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de>
Cc: stable@vger.kernel.org
Cc: Huang Shijie <b32...@freescale.com>
Cc: Brian Norris <computersforpe...@gmail.com>
Cc: Subodh Nijsure <snijs...@grid-net.com>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 6bb6f48..0179685 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -920,12 +920,12 @@ static int gpmi_ecc_read_page(struct mtd_info *mtd,
struct nand_chip *chip,
*/
memset(chip->oob_poi, ~0, mtd->oobsize);
chip->oob_poi[0] = ((uint8_t *) auxiliary_virt)[0];
-
- read_page_swap_end(this, buf, mtd->writesize,
- this->payload_virt, this->payload_phys,
- nfc_geo->payload_size,
- payload_virt, payload_phys);
}
+
+ read_page_swap_end(this, buf, mtd->writesize,
+ this->payload_virt, this->payload_phys,
+ nfc_geo->payload_size,
+ payload_virt, payload_phys);
exit_nfc:
return ret;
}
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
