Wilmer reported continuous suspend/resume does not work after
commit 928bea964827 ("PCI: Delay enabling bridges until they're needed").For pci bridge without driver, FW enable it already. In pci_pm_resume/pci_pm_reenable_device after first resume will not reenable the device, aka the status is not the same as that before first suspend. Try to update enable status according to register value before calling pci_reenable_device, so we will not miss those pm operation calling for next suspend/resume. Link: https://bugzilla.kernel.org/show_bug.cgi?id=86421 Fixes: 928bea964827 ("PCI: Delay enabling bridges until they're needed") Reported-by: Wilmer van der Gaast <[email protected]> Bisected-by: Wilmer van der Gaast <[email protected]> Tested-by: Wilmer van der Gaast <[email protected]> Signed-off-by: Yinghai Lu <[email protected]> Cc: Zhang Rui <[email protected]> CC: [email protected] # v3.10+ --- drivers/pci/pci-driver.c | 9 +++++++++ 1 file changed, 9 insertions(+) Index: linux-2.6/drivers/pci/pci-driver.c =================================================================== --- linux-2.6.orig/drivers/pci/pci-driver.c +++ linux-2.6/drivers/pci/pci-driver.c @@ -519,8 +519,17 @@ static void pci_pm_set_unknown_state(str */ static int pci_pm_reenable_device(struct pci_dev *pci_dev) { + u16 cmd; int retval; + /* update enable_cnt according to cmd register */ + pci_read_config_word(pci_dev, PCI_COMMAND, &cmd); + if (!pci_dev->is_busmaster && (cmd & PCI_COMMAND_MASTER)) + pci_dev->is_busmaster = true; + if (!pci_is_enabled(pci_dev) && + (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY))) + atomic_inc(&pci_dev->enable_cnt); + /* if the device was enabled before suspend, reenable */ retval = pci_reenable_device(pci_dev); /* -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
