Hello.
On 1/20/2015 3:25 PM, Mugunthan V N wrote:
In Dual EMAC, the default vlans are used to segregate rx packets between
VLANs. And RX.
the ports, so adding the same default vlan to the switch will affect the
VLAN.
normal packet transfers. So returning error on addition of dual emac
EMAC.
default vlans.
VLANs.
Even if emac 0 default port vlan is added to emac 1, it will lead to
EMAC. And VLAN
break
Breaking.
dual EMAC port seperations.
Separations.
Fixes: d9ba8f9 (driver: net: ethernet: cpsw: dual emac interface implementation)
12 hex digits, please.
Cc: <[email protected]> # v3.9+
Reported-by: Felipe Balbi <[email protected]>
Signed-off-by: Mugunthan V N <[email protected]>
---
drivers/net/ethernet/ti/cpsw.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index e068d48..7c32815 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1683,6 +1683,19 @@ static int cpsw_ndo_vlan_rx_add_vid(struct net_device
*ndev,
if (vid == priv->data.default_vlan)
return 0;
+ if (priv->data.dual_emac) {
+ /* In dual EMAC, reserved VLAN id should not be used of
s/of/for/, perhaps?
+ * creating vlan interfaces as this can break the dual
s/vlan/VLAN/. Be consistent, please.
+ * EMAC port seperation
Separation.
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
