Ben, On Jul 9, 2012, at 7:32 AM, Ben Hutchings wrote:
> 3.2-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Mark Rustad <[email protected]> > > commit 863555be0c81558b1af277addcf68acb8f778860 upstream. > > Use rcu_dereference_protected to tell rcu that the ft_lport_lock > is held during ft_lport_create. This resolved "suspicious RCU usage" > warnings when debugging options are turned on. > > Signed-off-by: Mark Rustad <[email protected]> > Tested-by: Ross Brattain <[email protected]> > Signed-off-by: Nicholas Bellinger <[email protected]> > Signed-off-by: Ben Hutchings <[email protected]> > --- > drivers/target/tcm_fc/tfc_sess.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/target/tcm_fc/tfc_sess.c > b/drivers/target/tcm_fc/tfc_sess.c > index cb99da9..87901fa 100644 > --- a/drivers/target/tcm_fc/tfc_sess.c > +++ b/drivers/target/tcm_fc/tfc_sess.c > @@ -58,7 +58,8 @@ static struct ft_tport *ft_tport_create(struct fc_lport > *lport) > struct ft_tport *tport; > int i; > > - tport = rcu_dereference(lport->prov[FC_TYPE_FCP]); > + tport = rcu_dereference_protected(lport->prov[FC_TYPE_FCP], > + lockdep_is_held(&ft_lport_lock)); > if (tport && tport->tpg) > return tport; I'm sorry, please disregard my previous message. I was thinking of the wrong patch. As far as I know, this patch is fine. -- Mark Rustad, LAN Access Division, Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
