This is a note to let you know that I've just added the patch titled

    power: gpio-charger: balance enable/disable_irq_wake calls

to the 3.18-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     power-gpio-charger-balance-enable-disable_irq_wake-calls.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From faeed51bb65ce0241052d8dc24ac331ade12e976 Mon Sep 17 00:00:00 2001
From: Dmitry Eremin-Solenikov <[email protected]>
Date: Thu, 15 Jan 2015 05:00:37 +0300
Subject: power: gpio-charger: balance enable/disable_irq_wake calls

From: Dmitry Eremin-Solenikov <[email protected]>

commit faeed51bb65ce0241052d8dc24ac331ade12e976 upstream.

enable_irq_wakeup returns 0 in case it correctly enabled the IRQ to
generate the wakeup event (and thus resume should call disable_irq_wake).
Currently gpio-charger driver has this logic inverted. Correct that thus
correcting enable/disable_irq_wake() calls balance.

Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
Signed-off-by: Sebastian Reichel <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 drivers/power/gpio-charger.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/power/gpio-charger.c
+++ b/drivers/power/gpio-charger.c
@@ -168,7 +168,7 @@ static int gpio_charger_suspend(struct d
 
        if (device_may_wakeup(dev))
                gpio_charger->wakeup_enabled =
-                       enable_irq_wake(gpio_charger->irq);
+                       !enable_irq_wake(gpio_charger->irq);
 
        return 0;
 }
@@ -178,7 +178,7 @@ static int gpio_charger_resume(struct de
        struct platform_device *pdev = to_platform_device(dev);
        struct gpio_charger *gpio_charger = platform_get_drvdata(pdev);
 
-       if (gpio_charger->wakeup_enabled)
+       if (device_may_wakeup(dev) && gpio_charger->wakeup_enabled)
                disable_irq_wake(gpio_charger->irq);
        power_supply_changed(&gpio_charger->charger);
 


Patches currently in stable-queue which might be from [email protected] are

queue-3.18/power-gpio-charger-balance-enable-disable_irq_wake-calls.patch
queue-3.18/arm-8284-1-sa1100-clear-rcsr_smr-on-resume.patch
queue-3.18/arm-pxa-add-regulator_has_full_constraints-to-corgi-board-file.patch
queue-3.18/arm-pxa-add-regulator_has_full_constraints-to-poodle-board-file.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to