I run into the same regression in s2ram between v3.5-rc6 and v3.5-rc7. This patch helps. Thanks.
Tested-by: Konstantin Khlebnikov <[email protected]> John Stultz wrote:
From: Thomas Gleixner<[email protected]> Linus, Since Thomas is on vacation I wanted to send you his fix to resolve the suspend regression from the leapsecond fixes. thanks -john The leap second rework unearthed another issue of inconsistent data. On timekeeping_resume() the timekeeper data is updated, but nothing calls timekeeping_update(), so now the update code in the timer interrupt sees stale values. This has been the case before those changes, but then the timer interrupt was using stale data as well so this went unnoticed for quite some time. Add the missing update call, so all the data is consistent everywhere. Reported-by: Andreas Schwab<[email protected]> Reported-by-and-tested-by: "Rafael J. Wysocki"<[email protected]> CC: LKML<[email protected]> Cc: Linux PM list<[email protected]> Cc: John Stultz<[email protected]> Cc: Ingo Molnar<[email protected]> Cc: Peter Zijlstra<[email protected]>, Cc: Prarit Bhargava<[email protected]> Cc: [email protected] Signed-off-by: Thomas Gleixner<[email protected]> Signed-off-by: John Stultz<[email protected]> --- kernel/time/timekeeping.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 269b1fe..3447cfa 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -717,6 +717,7 @@ static void timekeeping_resume(void) timekeeper.clock->cycle_last = timekeeper.clock->read(timekeeper.clock); timekeeper.ntp_error = 0; timekeeping_suspended = 0; + timekeeping_update(false); write_sequnlock_irqrestore(&timekeeper.lock, flags); touch_softlockup_watchdog();
-- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
