This is a note to let you know that I've just added the patch titled
openvswitch: Return vport module ref before destruction
to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
openvswitch-return-vport-module-ref-before-destruction.patch
and it can be found in the queue-3.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From foo@baz Tue Apr 21 23:05:14 CEST 2015
From: Thomas Graf <[email protected]>
Date: Mon, 30 Mar 2015 13:57:41 +0200
Subject: openvswitch: Return vport module ref before destruction
From: Thomas Graf <[email protected]>
[ Upstream commit fa2d8ff4e3522b4e05f590575d3eb8087f3a8cdc ]
Return module reference before invoking the respective vport
->destroy() function. This is needed as ovs_vport_del() is not
invoked inside an RCU read side critical section so the kfree
can occur immediately before returning to ovs_vport_del().
Returning the module reference before ->destroy() is safe because
the module unregistration is blocked on ovs_lock which we hold
while destroying the datapath.
Fixes: 62b9c8d0372d ("ovs: Turn vports with dependencies into separate modules")
Reported-by: Pravin Shelar <[email protected]>
Signed-off-by: Thomas Graf <[email protected]>
Acked-by: Pravin B Shelar <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/openvswitch/vport.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -274,10 +274,8 @@ void ovs_vport_del(struct vport *vport)
ASSERT_OVSL();
hlist_del_rcu(&vport->hash_node);
-
- vport->ops->destroy(vport);
-
module_put(vport->ops->owner);
+ vport->ops->destroy(vport);
}
/**
Patches currently in stable-queue which might be from [email protected] are
queue-3.19/skbuff-do-not-scrub-skb-mark-within-the-same-name-space.patch
queue-3.19/openvswitch-return-vport-module-ref-before-destruction.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
