This is a note to let you know that I've just added the patch titled

    Btrfs: use kmem_cache_free when freeing entry in inode cache

to the 3.10-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     btrfs-use-kmem_cache_free-when-freeing-entry-in-inode-cache.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From c3f4a1685bb87e59c886ee68f7967eae07d4dffa Mon Sep 17 00:00:00 2001
From: Filipe Manana <[email protected]>
Date: Sat, 13 Jun 2015 06:52:56 +0100
Subject: Btrfs: use kmem_cache_free when freeing entry in inode cache

From: Filipe Manana <[email protected]>

commit c3f4a1685bb87e59c886ee68f7967eae07d4dffa upstream.

The free space entries are allocated using kmem_cache_zalloc(),
through __btrfs_add_free_space(), therefore we should use
kmem_cache_free() and not kfree() to avoid any confusion and
any potential problem. Looking at the kfree() definition at
mm/slab.c it has the following comment:

  /*
   * (...)
   *
   * Don't free memory not originally allocated by kmalloc()
   * or you will run into trouble.
   */

So better be safe and use kmem_cache_free().

Signed-off-by: Filipe Manana <[email protected]>
Reviewed-by: David Sterba <[email protected]>
Signed-off-by: Chris Mason <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 fs/btrfs/inode-map.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/btrfs/inode-map.c
+++ b/fs/btrfs/inode-map.c
@@ -283,7 +283,7 @@ void btrfs_unpin_free_ino(struct btrfs_r
                __btrfs_add_free_space(ctl, info->offset, count);
 free:
                rb_erase(&info->offset_index, rbroot);
-               kfree(info);
+               kmem_cache_free(btrfs_free_space_cachep, info);
        }
 }
 


Patches currently in stable-queue which might be from [email protected] are

queue-3.10/btrfs-use-kmem_cache_free-when-freeing-entry-in-inode-cache.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to