This is a note to let you know that I've just added the patch titled

    cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode

to the 3.5-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     cgroup-cgroup_rm_files-was-calling-simple_unlink-with-the-wrong-inode.patch
and it can be found in the queue-3.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From ce27e317ba22b359bde02216afab934dac3af095 Mon Sep 17 00:00:00 2001
From: Tejun Heo <[email protected]>
Date: Tue, 3 Jul 2012 10:38:06 -0700
Subject: cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong 
inode

From: Tejun Heo <[email protected]>

commit ce27e317ba22b359bde02216afab934dac3af095 upstream.

While refactoring cgroup file removal path, 05ef1d7c4a "cgroup:
introduce struct cfent" incorrectly changed the @dir argument of
simple_unlink() to the inode of the file being deleted instead of that
of the containing directory.

The effect of this bug is minor - ctime and mtime of the parent
weren't properly updated on file deletion.

Fix it by using @cgrp->dentry->d_inode instead.

Signed-off-by: Tejun Heo <[email protected]>
Reported-by: Al Viro <[email protected]>
Acked-by: Li Zefan <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 kernel/cgroup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -954,7 +954,7 @@ static int cgroup_rm_file(struct cgroup
 
                dget(d);
                d_delete(d);
-               simple_unlink(d->d_inode, d);
+               simple_unlink(cgrp->dentry->d_inode, d);
                list_del_init(&cfe->node);
                dput(d);
 


Patches currently in stable-queue which might be from [email protected] are

queue-3.5/cgroup-cgroup_rm_files-was-calling-simple_unlink-with-the-wrong-inode.patch
queue-3.5/workqueue-perform-cpu-down-operations-from-low-priority-cpu_notifier.patch
queue-3.5/scsi-avoid-dangling-pointer-in-scsi_requeue_command.patch
queue-3.5/scsi-fix-device-removal-null-pointer-dereference.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to