Hi Alexander,

On 08/10/2012 08:16 AM, Alexander Holler wrote:
> Hello Greg,
> 
> I've posted an identical patch for udlfb too. Could you consider adding
> that patch too?

Uhm, that won't work. Things have to reach mainline before they are
applied to stable. If Bernie does not react, please resend your patch as
your initial mail didn't reach the fbdev-list for some reason nor my
private inbox.


Best regards,

Florian Tobias Schandinat

> 
> See https://lkml.org/lkml/2012/4/20/485
> 
> Regards,
> 
> Alexander
> 
> Am 09.08.2012 20:54, schrieb [email protected]:
>>
>> This is a note to let you know that I've just added the patch titled
>>
>>      video/smscufx: fix line counting in fb_write
>>
>> to the 3.5-stable tree which can be found at:
>>     
>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>>
>> The filename of the patch is:
>>       video-smscufx-fix-line-counting-in-fb_write.patch
>> and it can be found in the queue-3.5 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <[email protected]> know about it.
>>
>>
>>  From 2fe2d9f47cfe1a3e66e7d087368b3d7155b04c15 Mon Sep 17 00:00:00 2001
>> From: Alexander Holler <[email protected]>
>> Date: Sat, 21 Apr 2012 00:11:07 +0200
>> Subject: video/smscufx: fix line counting in fb_write
>>
>> From: Alexander Holler <[email protected]>
>>
>> commit 2fe2d9f47cfe1a3e66e7d087368b3d7155b04c15 upstream.
>>
>> Line 0 and 1 were both written to line 0 (on the display) and all
>> subsequent
>> lines had an offset of -1. The result was that the last line on the
>> display
>> was never overwritten by writes to /dev/fbN.
>>
>> The origin of this bug seems to have been udlfb.
>>
>> Signed-off-by: Alexander Holler <[email protected]>
>> Signed-off-by: Florian Tobias Schandinat <[email protected]>
>> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>>
>> ---
>>   drivers/video/smscufx.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/video/smscufx.c
>> +++ b/drivers/video/smscufx.c
>> @@ -904,7 +904,7 @@ static ssize_t ufx_ops_write(struct fb_i
>>       result = fb_sys_write(info, buf, count, ppos);
>>
>>       if (result > 0) {
>> -        int start = max((int)(offset / info->fix.line_length) - 1, 0);
>> +        int start = max((int)(offset / info->fix.line_length), 0);
>>           int lines = min((u32)((result / info->fix.line_length) + 1),
>>                   (u32)info->var.yres);
>>
>>
>>
>> Patches currently in stable-queue which might be from
>> [email protected] are
>>
>> queue-3.5/video-smscufx-fix-line-counting-in-fb_write.patch
>>
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to