3.2.73-rc1 review patch. If anyone has any objections, please let me know.
------------------ From: Richard Weinberger <[email protected]> commit 281fda27673f833a01d516658a64d22a32c8e072 upstream. Make sure that data_size is less than LEB size. Otherwise a handcrafted UBI image is able to trigger an out of bounds memory access in ubi_compare_lebs(). Signed-off-by: Richard Weinberger <[email protected]> Reviewed-by: David Gstir <[email protected]> [bwh: Backported to 3.2: drop first argument to ubi_err()] Signed-off-by: Ben Hutchings <[email protected]> --- drivers/mtd/ubi/io.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/mtd/ubi/io.c +++ b/drivers/mtd/ubi/io.c @@ -943,6 +943,11 @@ static int validate_vid_hdr(const struct goto bad; } + if (data_size > ubi->leb_size) { + ubi_err("bad data_size"); + goto bad; + } + if (vol_type == UBI_VID_STATIC) { /* * Although from high-level point of view static volumes may -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
