This is a note to let you know that I've just added the patch titled

    netlink: Add missing goto statement to netlink_insert

to the 4.1-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     netlink-add-missing-goto-statement-to-netlink_insert.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From [email protected]  Tue Dec  8 22:28:59 2015
From: Herbert Xu <[email protected]>
Date: Tue, 8 Dec 2015 14:13:19 +0800
Subject: netlink: Add missing goto statement to netlink_insert
To: Stefan Priebe - Profihost AG <[email protected]>
Cc: Hannes Frederic Sowa <[email protected]>, Florian Weimer 
<[email protected]>, Thomas Gleixner <[email protected]>, 
[email protected], [email protected], 
[email protected], jannik Winkel <[email protected]>, Marco 
Schinkel <[email protected]>, "David S. Miller" <[email protected]>, 
[email protected]
Message-ID: <[email protected]>
Content-Disposition: inline

From: Herbert Xu <[email protected]>

The backport of 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink:
Fix autobind race condition that leads to zero port ID") missed a
goto statement, which causes netlink to break subtly.

This was discovered by Stefan Priebe <[email protected]>.

Fixes: 4e2776241766 ("netlink: Fix autobind race condition that...")
Reported-by: Stefan Priebe <[email protected]>
Reported-by: Philipp Hahn <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
Acked-by: David S. Miller <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 net/netlink/af_netlink.c |    1 +
 1 file changed, 1 insertion(+)

--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1118,6 +1118,7 @@ static int netlink_insert(struct sock *s
                if (err == -EEXIST)
                        err = -EADDRINUSE;
                sock_put(sk);
+               goto err;
        }
 
        /* We need to ensure that the socket is hashed and visible. */


Patches currently in stable-queue which might be from 
[email protected] are

queue-4.1/netlink-add-missing-goto-statement-to-netlink_insert.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to