Hi, Francois Romieu wrote:
> From: françois romieu <[email protected]> > > commit 811fd3010cf512f2e23e6c4c912aad54516dc706 upstream. > > Realtek has specified that the post 8168c gigabit chips and the post > 8105e fast ethernet chips recover automatically from a Rx FIFO overflow. > The driver does not need to clear the RxFIFOOver bit of IntrStatus and > it should rather avoid messing it. First, thanks much for doing this work for the 3.0.y driver. The patch generally makes sense.[1] > --- a/drivers/net/r8169.c > +++ b/drivers/net/r8169.c > @@ -1088,11 +1088,13 @@ static u8 rtl8168d_efuse_read(void __iomem *ioaddr, > int reg_addr) > return value; > } > > -static void rtl8169_irq_mask_and_ack(void __iomem *ioaddr) > +static void rtl8169_irq_mask_and_ack(struct rtl8169_private *tp) > { > - RTL_W16(IntrMask, 0x0000); > + void __iomem *ioaddr = tp->mmio_addr; Doesn't rtl8169_asic_down (and its callers) need to be adjusted to follow the new calling convention, too? With that change, it seems likely it will avoid Tx queue timeouts in Debian squeeze, though I haven't been able to find someone to test: see <http://bugs.debian.org/642911>. Thanks and hope that helps, Jonathan [1] The original would have been clearer split up into one patch for each of the four or so things it does, but that's water under the bridge. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
