commit: 50df9fd55e4271e89a7adf3b1172083dd0ca199d
From: Herton Ronaldo Krzesinski <[email protected]>
Date: Sun, 23 Sep 2012 22:49:12 -0400
Subject: ext4: fix crash when accessing /proc/mounts concurrently
The crash was caused by a variable being erronously declared static in
token2str().
In addition to /proc/mounts, the problem can also be easily replicated
by accessing /proc/fs/ext4/<partition>/options in parallel:
$ cat /proc/fs/ext4/<partition>/options > options.txt
... and then running the following command in two different terminals:
$ while diff /proc/fs/ext4/<partition>/options options.txt; do true; done
This is also the cause of the following a crash while running xfstests
#234, as reported in the following bug reports:
https://bugs.launchpad.net/bugs/1053019
https://bugzilla.kernel.org/show_bug.cgi?id=47731
Signed-off-by: Herton Ronaldo Krzesinski <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>
Cc: Brad Figg <[email protected]>
Cc: [email protected]
---
fs/ext4/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e6784b3..7bef0a4 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1749,7 +1749,7 @@ static inline void ext4_show_quota_options(struct
seq_file *seq,
static const char *token2str(int token)
{
- static const struct match_token *t;
+ const struct match_token *t;
for (t = tokens; t->token != Opt_err; t++)
if (t->token == token && !strchr(t->pattern, '='))
--
1.7.3.4
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
