This is a note to let you know that I've just added the patch titled
eCryptfs: Write out all dirty pages just before releasing the lower file
to the 3.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ecryptfs-write-out-all-dirty-pages-just-before-releasing-the-lower-file.patch
and it can be found in the queue-3.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 7149f2558d5b5b988726662fe58b1c388337805b Mon Sep 17 00:00:00 2001
From: Tyler Hicks <[email protected]>
Date: Wed, 12 Sep 2012 18:02:46 -0700
Subject: eCryptfs: Write out all dirty pages just before releasing the lower
file
From: Tyler Hicks <[email protected]>
commit 7149f2558d5b5b988726662fe58b1c388337805b upstream.
Fixes a regression caused by:
821f749 eCryptfs: Revert to a writethrough cache model
That patch reverted some code (specifically, 32001d6f) that was
necessary to properly handle open() -> mmap() -> close() -> dirty pages
-> munmap(), because the lower file could be closed before the dirty
pages are written out.
Rather than reapplying 32001d6f, this approach is a better way of
ensuring that the lower file is still open in order to handle writing
out the dirty pages. It is called from ecryptfs_release(), while we have
a lock on the lower file pointer, just before the lower file gets the
final fput() and we overwrite the pointer.
https://launchpad.net/bugs/1047261
Signed-off-by: Tyler Hicks <[email protected]>
Reported-by: Artemy Tregubenko <[email protected]>
Tested-by: Artemy Tregubenko <[email protected]>
Tested-by: Colin Ian King <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
fs/ecryptfs/main.c | 1 +
1 file changed, 1 insertion(+)
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -162,6 +162,7 @@ void ecryptfs_put_lower_file(struct inod
inode_info = ecryptfs_inode_to_private(inode);
if (atomic_dec_and_mutex_lock(&inode_info->lower_file_count,
&inode_info->lower_file_mutex)) {
+ filemap_write_and_wait(inode->i_mapping);
fput(inode_info->lower_file);
inode_info->lower_file = NULL;
mutex_unlock(&inode_info->lower_file_mutex);
Patches currently in stable-queue which might be from [email protected] are
queue-3.4/ecryptfs-unlink-lower-inode-when-ecryptfs_create-fails.patch
queue-3.4/ecryptfs-call-lower-flush-from-ecryptfs_flush.patch
queue-3.4/ecryptfs-write-out-all-dirty-pages-just-before-releasing-the-lower-file.patch
queue-3.4/ecryptfs-revert-to-a-writethrough-cache-model.patch
queue-3.4/ecryptfs-initialize-empty-lower-files-when-opening-them.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
