commit: b4dd784ba8af03bf1f9ee5118c792d7abd4919bd From: Wei Yongjun <[email protected]> Date: Mon, 22 Oct 2012 12:58:09 +0800 Subject: pinctrl: fix missing unlock on error in pinctrl_groups_show()
Add the missing unlock on the error handle path in function pinctrl_groups_show(). Cc: [email protected] Signed-off-by: Wei Yongjun <[email protected]> Signed-off-by: Linus Walleij <[email protected]> --- drivers/pinctrl/core.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 0f1ec9e..2e39c04 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1061,8 +1061,10 @@ static int pinctrl_groups_show(struct seq_file *s, void *what) seq_printf(s, "group: %s\n", gname); for (i = 0; i < num_pins; i++) { pname = pin_get_name(pctldev, pins[i]); - if (WARN_ON(!pname)) + if (WARN_ON(!pname)) { + mutex_unlock(&pinctrl_mutex); return -EINVAL; + } seq_printf(s, "pin %d (%s)\n", pins[i], pname); } seq_puts(s, "\n"); -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
